Skip to content

Rename const error methods for consistency #111570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 15, 2023
Merged

Rename const error methods for consistency #111570

merged 1 commit into from
May 15, 2023

Conversation

compiler-errors
Copy link
Member

@compiler-errors compiler-errors commented May 14, 2023 •
edited by BoxyUwU
Loading

renames ty::Const's methods for creating a ConstKind::Error to be in the same naming style as ty::Ty's equivalent methods.

r? @BoxyUwU

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels May 14, 2023
@rustbot
Copy link
Collaborator

rustbot commented May 14, 2023

Some changes occurred in rustc_ty_utils::consts.rs

cc @BoxyUwU

Some changes occurred in abstract_const.rs

cc @BoxyUwU

@BoxyUwU
Copy link
Member

BoxyUwU commented May 14, 2023

@bors r+ rollup=never

@bors
Copy link
Collaborator

bors commented May 14, 2023

📌 Commit 8e163f9 has been approved by BoxyUwU

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 14, 2023
@bors
Copy link
Collaborator

bors commented May 15, 2023

⌛ Testing commit 8e163f9 with merge 8d18c32...

@bors
Copy link
Collaborator

bors commented May 15, 2023

☀️ Test successful - checks-actions
Approved by: BoxyUwU
Pushing 8d18c32 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label May 15, 2023
@bors bors merged commit 8d18c32 into rust-lang:master May 15, 2023
@rustbot rustbot added this to the 1.71.0 milestone May 15, 2023
This was referenced May 15, 2023
Closed
Closed
Merged
Closed
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (8d18c32): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 4.8% [4.5%, 5.4%] 3
Regressions ❌
(secondary)		 2.4% [2.4%, 2.4%] 1
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -3.1% [-3.5%, -2.7%] 2
All ❌✅ (primary) 4.8% [4.5%, 5.4%] 3

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 642.634s -> 643.398s (0.12%)

@BoxyUwU BoxyUwU mentioned this pull request May 16, 2023
Merged
@compiler-errors compiler-errors deleted the ct-err branch August 11, 2023 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@BoxyUwU BoxyUwU

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.71.0
Development

Successfully merging this pull request may close these issues.
5 participants
@compiler-errors @rustbot @BoxyUwU @bors @rust-timer